Fix Sentry WORDPRESS-ANDROID-3F8W: skip Sentry for empty_fetch_params#22889
Closed
nbradbury wants to merge 1 commit into
Closed
Fix Sentry WORDPRESS-ANDROID-3F8W: skip Sentry for empty_fetch_params#22889nbradbury wants to merge 1 commit into
nbradbury wants to merge 1 commit into
Conversation
Sibling of the issues silenced in #22846. When the deep-link callback arrives with one of username/password/siteUrl/apiRootUrl missing, fetchSites emits an "empty_fetch_params" error to the UI and tracks the failure via trackStoringFailed — but also fired a crash report because emitError defaulted reportToSentry=true. ~463 users affected. Pass reportToSentry=false so the UI surfacing and analytics tracking remain, but the Sentry noise stops. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Collaborator
Generated by 🚫 Danger |
Contributor
Author
|
Closing, I don't think this fix is necessary. |
Contributor
|
|
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes WORDPRESS-ANDROID-3F8W —
Application password login failed: empty_fetch_params(~463 users / ~720 events).Sibling of the issues silenced in #22846. When the deep-link callback arrives with one of
username/password/siteUrl/apiRootUrlmissing — most commonlyapiRootUrlnot present in the URI —fetchSitesemits anempty_fetch_paramserror to the UI and tracks the failure viatrackStoringFailed(..., "empty_fetch_params"). It was also firing a crash report becauseemitErrordefaulted toreportToSentry = true. #22846 added thereportToSentryflag and silenced theempty_credentials/site_not_found/no_rows_affectedvalidation outcomes, but missed this earlier check.What changed
fetchSitesnow passesreportToSentry = falsefor theempty_fetch_paramsbranch. The UI surfacing and analytics tracking are unchanged — only the Sentry noise stops.Test plan
🤖 Generated with Claude Code