Repository navigation
Make CookieJar and request authentication async - #26104
Draft
crazytonyli wants to merge 1 commit into
Draft
crazytonyli wants to merge 1 commit into
crazytonyli wants to merge 1 commit into
Conversation
Collaborator
Generated by 🚫 Danger |
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 35553 | |
| Version | PR #26104 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 9d113da | |
| Installation URL | 5jflo36nbpim8 |
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 35553 | |
| Version | PR #26104 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 9d113da | |
| Installation URL | 4mn6ctt4ljtdo |
crazytonyli
force-pushed
the
task/cookiejar-async
branch
from
October 1, 2026 02:43
322568c to
565132b
Compare
crazytonyli
changed the base branch from
task/cookiejar-remove-unused-code
to
task/cookiejar-behavior-changes
October 1, 2026 02:43
crazytonyli
force-pushed
the
task/cookiejar-async
branch
from
October 11, 2026 20:13
565132b to
4038335
Compare
crazytonyli
force-pushed
the
task/cookiejar-async
branch
from
October 29, 2026 07:03
4038335 to
9d113da
Compare
crazytonyli
force-pushed
the
task/cookiejar-async
branch
from
October 29, 2026 20:51
9d113da to
8d9a5d0
Compare
CookieJar now has three async requirements that the system cookie stores mostly satisfy with their own methods. AuthenticationService, AtomicAuthenticationService and RequestAuthenticator gain async methods; RequestAuthenticator keeps completion-handler variants so its callers are unchanged. Behaviour is unchanged, except that those completion handlers are now always called asynchronously on the main thread.
crazytonyli
force-pushed
the
task/cookiejar-async
branch
from
October 29, 2026 23:10
8d9a5d0 to
1fdcb3d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The system cookie stores already provide most of the operations
CookieJarneeds. Using async methods lets them satisfy the protocol directly and removes custom callback handling from cookie storage and authentication.RequestAuthenticatorkeeps its completion-handler API so existing callers do not need to migrate together. Request completions now run asynchronously on the main thread. Navigation decisions that allow loading still complete synchronously.Account removal still clears shared HTTP cookies synchronously, so delayed cleanup cannot delete cookies belonging to the next account.