Repository navigation
Block the app with a sign-in gate when the WordPress.com token is missing - #26130
Draft
crazytonyli wants to merge 2 commits into
Draft
crazytonyli wants to merge 2 commits into
crazytonyli wants to merge 2 commits into
Conversation
Collaborator
Generated by 🚫 Danger |
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 34902 | |
| Version | PR #26130 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 0187850 | |
| Installation URL | 1abp62iih9p58 |
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 34902 | |
| Version | PR #26130 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 0187850 | |
| Installation URL | 1s1330bv0iltg |
crazytonyli
force-pushed
the
task/wpcom-reauthentication-gate
branch
from
October 13, 2026 00:39
a4b3968 to
f9a4f7a
Compare
crazytonyli
changed the base branch from
trunk
to
task/wpcom-token-less-account-fixes
October 13, 2026 00:58
crazytonyli
force-pushed
the
task/wpcom-reauthentication-gate
branch
from
October 13, 2026 01:20
f9a4f7a to
763d7d3
Compare
crazytonyli
marked this pull request as ready for review
October 13, 2026 01:33
crazytonyli
force-pushed
the
task/wpcom-reauthentication-gate
branch
from
October 13, 2026 01:33
763d7d3 to
0187850
Compare
Contributor
|
Version |
crazytonyli
force-pushed
the
task/wpcom-reauthentication-gate
branch
from
October 29, 2026 00:13
0187850 to
6dd8b0f
Compare
Contributor
|
I see we've been added a reviewers on this one, but looking at the diff this branch (and PR stack) clearly needs a clean rebase before even consider merging/reviewing, as its diff includes a lot more things than it is supposed to, like bumps in the |
crazytonyli
force-pushed
the
task/wpcom-reauthentication-gate
branch
from
October 29, 2026 20:48
6dd8b0f to
c7242d9
Compare
Contributor
🤖 Build Failure AnalysisThis build has failures. Claude has analyzed them - check the build annotations for details. |
…sing The "Log out / Sign In" alert shown after cancelling the web sign-in was presented on the window's root view controller, so UIKit dropped it whenever the root was already presenting something, such as the "Your Sites" tip. The app also never asked for sign-in when the token was missing at launch. A gate in the window manager's alert-level overlay window now offers only Sign In and Log out. It appears at launch, on foreground, and when a request is rejected, stays until the account has a token or is removed, and follows the scene when the system reconnects it.
crazytonyli
force-pushed
the
task/wpcom-reauthentication-gate
branch
from
October 29, 2026 23:05
c7242d9 to
a1fa87d
Compare
Contributor
Author
|
@AliSoftware I think you were notified to review the PR because of the rebase brought in some trunk changes. Sorry for the noise. |
crazytonyli
marked this pull request as draft
October 30, 2026 00:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Users can currently cancel WordPress.com sign-in and keep using the app with no token. Cached content still looks available, but requests fail. The fallback "Log out / Sign In" alert can be dropped when the root view controller is already presenting something, such as the "Your Sites" tip.
The app now shows a blocking screen offering Sign In and Log out until the account has a token again or is removed. Cancelling web sign-in returns to this screen, keeping the recovery options available.
The screen uses
WindowManager's overlaying window so existing presentations cannot hide it. It also checks at launch and on foreground: relying on an API request to trigger sign-in misses users whose screens never access the v1 API getter.