Repository navigation
Conversation
…ties The compact card was only used in phase four, and featureName and isPlural only built the phase three badge text. Both phases are gone, so this code can no longer run.
Collaborator
Generated by 🚫 Danger |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes two pieces of Jetpack branding code that can no longer run since #26281 deleted the unreachable removal phases. Users see no change.
Changes
cardConfig()now only ever returns the expanded card. RemovesConfig.CardType, the sevenswitchproperties inJetpackBrandingMenuCardCell,Metrics.Compact, and the compact-only views and strings.Metrics.Expandedis now justMetrics.JetpackBrandedScreen:featureNameandisPluralonly built the phase three badge text. With both gone the protocol is empty, so it goes too.JetpackBannerScreenandJetpackBadgeScreenstay, because their raw values are thescreenanalytics property.BlogDashboardCardFrameView.removeButtonContainerStackView(): the compact card was its only caller.The "Activity", "Menus" and "Sharing" strings no longer have an
NSLocalizedStringcall using them as a key.Localizable.stringsis generated at release time, so this PR doesn't edit it.The second commit only runs
swift-formaton the two files that weren't formatted yet. Review the first commit for the actual change.Test plan
JetpackBrandingMenuCardPresenterTestsandJetpackBrandingVisibilityTestson an iPhone 18 Pro (iOS 27.0) simulator: 8 tests, 0 failures. The full suite was not run locally; CI covers it.swift-formatand SwiftLint clean on every touched file…menu items on a device or simulator: not done. This PR doesn't change that code, and the menu items are covered by the view tree comparison above.