Repository navigation
Conversation
Rethrow the WorkOS SDK's ApiKeyRequiredException instead of swallowing it to null, and let the impersonation banner degrade when the action rejects.
Wrap the WorkOS SDK's ApiKeyRequiredException in an error naming WORKOS_API_KEY. The impersonation banner logs the rejection and renders without the organization name instead of leaving an unhandled rejection.
nicknisi
marked this pull request as ready for review
October 7, 2026 17:31
Contributor
|
A lookup for a previous organization that settles after the organization changed no longer overwrites the current name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bring keyless PKCE public clients to @workos/authkit-tanstack-react-start, the same experience as workos/authkit-react-router#96 (workos/authkit-react-router#96). It builds on the authkit-session change from the preceding job, whose branch and PR it names.
authkit-tanstack-start delegates to @workos/authkit-session (
src/server/authkit-loader.tscallscreateAuthServiceandgetConfig). So:riker/<n>-let-workos-authkit-session-run-as-a-keyle…or ask), via a pnpm override in this worktree only while developing. Never commit a file:, link: or override dependency.validateConfig, middleware options, anyconfigure/options types re-exported from authkit-session, and anything here that assumes an API key. Key-only features must surface authkit-session's clear error.example/: copy it to a scratch directory, point it at both packed builds (authkit-session and this package), run it with no WORKOS_API_KEY, and show the sign-in route redirects withcode_challengeand S256. Leave the dev server running and give Nick the URL and steps to sign in, see the session load, and see a refresh succeed.@workos/authkit-sessionrange. Say exactly which authkit-session release this needs, and whether the PR can merge before that release (e.g. if nothing here type-depends on the new union, it can; otherwise note that it must wait and bump the range when it's out).Riker's check
pnpm install --frozen-lockfile >/dev/null && git diff --quiet origin/main...HEAD -- pnpm-lock.yaml && ! grep -qE '"(file|link):' package.json example/package.json && pnpm typecheck && pnpm lint && pnpm format:check && pnpm test && pnpm buildpassed.Opened as a draft by Riker (job 98).