Repository navigation
Conversation
Contributor
|
stanleyphu
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hit the API's
Please provide either "after" or "before" parameters.error when callingautoPagination()on a list fetched withbefore: the first follow-up request re-sends the stalebeforealongside the newaftercursor, and the API rejects any request carrying both.before; they send onlyafter(the previous page'slistMetadata.after), so a walk started from abeforecursor pages forward instead of failing on the second request.Test plan
Red-first regression in
src/common/utils/pagination.spec.ts("paginates forward from a before cursor, dropping before on follow-up requests"), starting from{before: 'u21'}:{after: 'u12', before: 'u21', limit: 100}and call 3 as{after: 'u14', before: 'u21', limit: 100}— the both-cursors request the API rejects.{limit: 100, before: 'u21'}, follow-ups are{limit: 100, after: 'u12'}and{limit: 100, after: 'u14'}with nobefore, and the walk returns the three pages concatenated in order (u11, u12, u13, u14, u15).