Skip to content

Tests: Improve Windows compatibility #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
swissspidy merged 14 commits into from
Apr 10, 2026
Merged

Tests: Improve Windows compatibility #232

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
0d1213e
Use curl instead of wget in test
swissspidy Mar 28, 2026
08e15b6
Update features/package-install.feature
swissspidy Mar 28, 2026
cbefff3
Update some unit tests for Windows
swissspidy Mar 28, 2026
bc5dbbc
Update features/package-install.feature
swissspidy Mar 28, 2026
fcecbd6
tweak more tests
swissspidy Mar 28, 2026
0288e88
Normalize line endings
swissspidy Mar 29, 2026
9057bde
normalize slashes & mac paths
swissspidy Mar 29, 2026
0e9c869
Use `Runner::get_packages_dir_path()`
swissspidy Mar 31, 2026
aa9f5fe
Normalize some paths
swissspidy Apr 9, 2026
6d7b349
Update some tests for Windows
swissspidy Apr 9, 2026
6cf1f70
More normalization
swissspidy Apr 9, 2026
677c34d
Skip if it looks like a zip file
swissspidy Apr 9, 2026
3bb6883
Update tests
swissspidy Apr 9, 2026
6566fd2
Use regex assertion
swissspidy Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion features/package-install.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -957,7 +957,7 @@ Feature: Install WP-CLI packages

Scenario: Install a package from a local zip
Given an empty directory
And I run `wget -q -O google-sitemap-generator-cli.zip https://github.com/wp-cli/google-sitemap-generator-cli/archive/master.zip`
And I run `curl -sS -L -o google-sitemap-generator-cli.zip https://github.com/wp-cli/google-sitemap-generator-cli/archive/master.zip`
Comment thread
swissspidy marked this conversation as resolved.
Outdated

When I run `wp package install google-sitemap-generator-cli.zip`
Then STDOUT should contain:
Expand Down