Skip to content

Drop support for PHPUnit Polyfills v1 - #341

Merged
swissspidy merged 1 commit into
mainfrom
chore/drop-phpunit-polyfills-v1
Jul 28, 2026
Merged

Drop support for PHPUnit Polyfills v1#341
swissspidy merged 1 commit into
mainfrom
chore/drop-phpunit-polyfills-v1

Conversation

@swissspidy

@swissspidy swissspidy commented Jul 27, 2026

Copy link
Copy Markdown
Member

Drops support for yoast/phpunit-polyfills ^1.0, keeping constraints to ^2.0 || ^3.0 || ^4.0.

  • wp-cli-tests requires PHP >=7.2.24, whereas yoast/phpunit-polyfills v2+ requires PHP 7.1+ and PHPUnit 7.0+.
  • WP-CLI and its packages run on PHPUnit 7+, so legacy PHPUnit 4–6 polyfill support provided by v1 is no longer needed.

Summary by CodeRabbit

  • Chores
    • Updated the supported PHPUnit polyfills version range to use newer compatible releases.

@swissspidy swissspidy added this to the 5.1.12 milestone Jul 27, 2026
@swissspidy
swissspidy requested a review from a team as a code owner July 27, 2026 15:41
@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 937390f2-b572-49a6-b753-9be7d70f64f5

📥 Commits

Reviewing files that changed from the base of the PR and between 0af4e54 and 76475e6.

📒 Files selected for processing (1)
  • composer.json

📝 Walkthrough

Walkthrough

The Composer requirement for yoast/phpunit-polyfills now allows versions ^2.0, ^3.0, and ^4.0, removing support for ^1.0.

Changes

Dependency constraint

Layer / File(s) Summary
Update PHPUnit polyfill constraint
composer.json
The yoast/phpunit-polyfills requirement excludes version 1.x while retaining versions 2.x through 4.x.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: brianhenryie, ernilambar

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: removing PHPUnit Polyfills v1 support.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/drop-phpunit-polyfills-v1

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Jul 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@swissspidy swissspidy added scope:distribution Related to distribution and removed state:unsupported labels Jul 27, 2026
@swissspidy
swissspidy merged commit 7b76232 into main Jul 28, 2026
84 checks passed
@swissspidy
swissspidy deleted the chore/drop-phpunit-polyfills-v1 branch July 28, 2026 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope:distribution Related to distribution scope:testing Related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants