feat(entity-caching-1): raw event pipeline (draft)#2827
feat(entity-caching-1): raw event pipeline (draft)#2827SkArchon wants to merge 7 commits intojensneuse/entity-caching-v2from
Conversation
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (4)
📒 Files selected for processing (39)
✨ Finishing Touches📝 Generate docstrings
Comment |
This comment has been minimized.
This comment has been minimized.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## jensneuse/entity-caching-v2 #2827 +/- ##
==============================================================
Coverage ? 64.05%
==============================================================
Files ? 600
Lines ? 74399
Branches ? 4764
==============================================================
Hits ? 47659
Misses ? 25222
Partials ? 1518
🚀 New features to boost your workflow:
|
The raw-event pipeline previously depended on graphql-go-tools fields that only exist on the unmerged engine branch (per-event Timestamp, DataSource on MutationEvent/EntityFieldHash, FieldPath on EntityFieldHash, and the ForceHashAnalyticsKeys planner override). CI builds against the pinned go.mod version, which does not yet have those fields, so the package failed to compile. Use a single build-time timestamp for every event in a snapshot, drop the fields that the pinned engine does not expose, and rely on per-entity SDL configuration for KeyHash population until the engine bump lands. Also wire proto/wg/cosmo/cacheevents into make generate-go so the router and graphqlmetrics gen dirs stay in sync with `make generate`.
Router-nonroot image scan passed✅ No security vulnerabilities found in image: |
The graphqlmetrics CI workflow runs its own buf generate command rather than make generate-go, so the Makefile fix did not cover it. Add the new cacheevents proto path so CI does not delete the committed gen files.
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
✅ Actions performedReview triggered.
|
|
@claude review once |
There was a problem hiding this comment.
Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit at claude.ai/admin-settings/claude-code.
Once credits are available, comment @claude review on this pull request to trigger a review.
This PR has the following
Summary by CodeRabbit
Release Notes
New Features
events_exportsettings underentity_cachingto enable batch export of cache events to a backend service.Chores
Checklist
Open Source AI Manifesto
This project follows the principles of the Open Source AI Manifesto. Please ensure your contribution aligns with its principles.