Add Air Temple cartographer maps#29
Merged
Merged
Conversation
xefensor
marked this pull request as ready for review
July 21, 2026 23:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an initial in-world discovery path for the Air Temple. After Stage 2 begins, journeyman-or-higher cartographers sell an Air Temple Explorer Map for 12 emeralds and a compass. The map uses an exact target X for the nearest
retold:air_temple.The offer is appended lazily during server-side villager interaction so cartographers with saved offers from before the stage transition keep those trades and gain the new map without rerolling their profession. Failed structure searches are throttled per cartographer, and duplicate Air Temple map offers are prevented.
Updates the public roadmap, changelog, architecture/status documentation, and design-risk tracking. This implements the initial cartographer path discussed in #11 while leaving wider seed and upgraded-world retrogen verification visible.
Player or developer impact
Players gain a survival-friendly way to find the Stage 2 Air Temple without using
/locate. Existing cartographers remain compatible, and the trade is unavailable during Stage 1.Developers gain a data-driven structure destination tag and deterministic GameTest coverage for stage gating, saved-offer preservation, costs, exact marker coordinates, and duplicate prevention.
Validation
./gradlew build./gradlew runGameTestServer, when relevantAll 20 required GameTests passed. The developer verified the basic cartographer interaction and exact-map behavior in-game on 2026-07-22.
Still pending: wider multi-seed coverage, edited upgraded-world retrogen destinations, real dedicated-server interaction, and multiplayer purchases. One GameTest run also showed a brief vanilla-style map-rendering stall, which is recorded in the design-risk tracker for profiling.
AI assistance
Codex assisted with repository/GitHub triage, implementation, tests, and documentation. The result was validated with the complete Gradle build, the GameTest server, diff checks, and developer in-game confirmation.
Documentation and release notes
CHANGELOG.mdfor player-facing or notable technical changesVisual evidence
No screenshot or video was captured. The developer confirmed the basic exact-map behavior in-game.
Licensing
LICENSE-CODE.md.No creative assets are included in this PR.