Repository navigation
Move the Regex utilities and pattern types out of regex.rs - #1349
Merged
Merged
Conversation
Assertion, Set, Part and Class are built by the parser and read by the program and search, so they now live with the parser instead of the parent module.
The Regex utility functions, with their $name template expansion and replace loop, sat in the parent module. They now have their own child, named for the Utility enum, and the parent keeps the limits and helpers every child shares.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Collaborator
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VIBE-107.
regex.rsheld theRegex.match/replace/replace_allutilities, with their$nametemplate expansion and replace loop, and the pattern types the parser builds. The parent was the biggest place to look for code that belongs to its children. No behavior change.Assertion,Set,PartandClassmove toregex/parse.rs.Utilityfunctions move to a newregex/utility.rs, with the two tests that coverreplace. The parent re-exportsUtility, so callers are unchanged.git diff --color-movedshows only moves, apart frompub(super)on the moved pattern types andClass::matches, and the import lines.