Repository navigation
Move the Time constructors and fixed-layout renderers out of time.rs - #1350
Merged
Merged
Conversation
The fixed-layout renderers sat in the parent module while the Go layout renderer lived in format. The moved numeric_zone is renamed numeric_offset so it doesn't clash with format's layout-token numeric_zone.
Time.local, Time.utc, Time.at, Time.now and Time.parse sat in the parent module. They move with the argument helpers only they use: raw_int, scaled, Subsecond, unexpected_unit and required_year.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
# Conflicts: # src/time.rs # src/time/format.rs
Collaborator
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VIBE-107.
time.rsheld theTime.local/utc/at/now/parseconstructors and the RFC 3339 and mail-date renderers, whiletime/format.rsalready held the Go layout renderer. No behavior change.year,textandmail_datemove totime/format.rs. The movednumeric_zoneis renamednumeric_offsetso it doesn't clash with format's own layout-tokennumeric_zone.Constructormoves to a newtime/construct.rs, along with the helpers only it uses:raw_int,scaled,Subsecond,unexpected_unitandrequired_year. The card named onlyConstructor, but leaving its private helpers behind would have kept constructor code in the parent.git diff --color-movedshows only moves, apart from that rename,pub(super)onmail_date, and the import lines.