Repository navigation
Split src/syntax.rs into focused modules - #1352
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Collaborator
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src/syntax.rshad grown to about 4,900 lines: name validation, every AST type, and two impl blocks of about 1,800 and 1,600 lines, all next to 15 child modules. That made the parser hard to navigate and changes to it hard to review (VIBE-106).This PR only moves code; behavior doesn't change. Each commit moves one concern into a child module, following the
impl Parsing/impl Parsersplit thatmodules.rsandsuffixes.rsalready use.syntax.rsis down to 386 lines and keeps the declarations, re-exports, entry points and the task plumbing.Besides the moved lines, the diff only has:
modanduselines and the impl headerspub(super)on the items and the twodepthfields that are now used from another modulegit diff --color-moved=plainmarks every other line as moved.