Skip to content

Split src/syntax.rs into focused modules - #1352

Merged
mgomes merged 11 commits into
masterfrom
able/vibe-106
Oct 31, 2026
Merged

mgomes merged 11 commits into
masterfrom
able/vibe-106

Conversation

@mgomes

@mgomes mgomes commented Oct 31, 2026

Copy link
Copy Markdown
Collaborator

src/syntax.rs had grown to about 4,900 lines: name validation, every AST type, and two impl blocks of about 1,800 and 1,600 lines, all next to 15 child modules. That made the parser hard to navigate and changes to it hard to review (VIBE-106).

This PR only moves code; behavior doesn't change. Each commit moves one concern into a child module, following the impl Parsing / impl Parser split that modules.rs and suffixes.rs already use. syntax.rs is down to 386 lines and keeps the declarations, re-exports, entry points and the task plumbing.

Besides the moved lines, the diff only has:

  • the new mod and use lines and the impl headers
  • pub(super) on the items and the two depth fields that are now used from another module

git diff --color-moved=plain marks every other line as moved.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-31T07:19:10.144572Z 9047ef7 Manual request
🔒 Security Review ✅ Completed 2026-10-31T07:18:26.305683Z 9047ef7 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@mgomes

mgomes commented Oct 31, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Chef's kiss.

Reviewed commit: 9047ef7ee2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@mgomes
mgomes merged commit 21531eb into master Oct 31, 2026
12 checks passed
@mgomes
mgomes deleted the able/vibe-106 branch October 31, 2026 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant