Repository navigation
fix(manifest): reject a manifest that is not a mapping - #1185
Merged
Merged
Conversation
An empty file parses to None and a CSV passed by mistake parses to a string; both reached data.get() and died with AttributeError and a traceback. load_manifest now raises the same ValueError the other schema errors use, so the CLI prints one error line and exits 2.
Contributor
|
@bfs2021 is attempting to deploy a commit to the yashkewlani2020-gmailcom's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
faircode benchmarkwith an empty manifest, or with a file passed by mistake (a CSV), reacheddata.get(...)onNoneor on a string and died withAttributeErrorand a full traceback:Fixes #1177.
Fix
load_manifestchecks that the parsed document is a mapping and raises the sameValueErrorthe other schema errors use:The CLI's existing
ValueErrorhandling then prints oneerror:line and exits 2.run_benchmark's path prefix does not double up because the message already starts with the path.Testing
tests/test_manifest.py: empty file and non-mapping document both raiseValueErrorwith "must be a mapping".tests/test_cli.py: both inputs exit 2, print oneerror:line with the path, and noTraceback.manifest.py(verified by reverting it only).pytest tests/test_manifest.py→ 53 passed;pytest tests/test_cli.py -k benchmark→ 23 passed.ruff checkon the three files → clean.