Skip to content

fix: lint generated explainer code - #1211

Closed
Aaqibhafeezkhan wants to merge 2 commits into
yakew7:mainfrom
Aaqibhafeezkhan:fix/issue-1167-ruff-explainers
Closed

Aaqibhafeezkhan wants to merge 2 commits into
yakew7:mainfrom
Aaqibhafeezkhan:fix/issue-1167-ruff-explainers

Conversation

@Aaqibhafeezkhan

@Aaqibhafeezkhan Aaqibhafeezkhan commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Remove five unused NumPy imports, two unused variables, and three unnecessary static f-string prefixes from explainer Markdown code blocks.
  • Regenerate the corresponding Python files in explainers/code/.
  • Include explainers/code in the Ruff checks configured in Makefile and .pre-commit-config.yaml.

Validation

  • The requested Ruff command is ruff check faircode scripts tests explainers/code.

Closes #1167

@vercel

vercel Bot commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

@Aaqibhafeezkhan is attempting to deploy a commit to the yashkewlani2020-gmailcom's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions

Copy link
Copy Markdown

@yakew7 @propcgamer20-png @Shreyash0712 - new PR touching a path you own, please review.

@Aaqibhafeezkhan Aaqibhafeezkhan left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed all 10 reported lint issues at their Markdown sources, regenerated the matching Python files, and updated both Ruff entry points.

@yakew7 yakew7 closed this Oct 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ruff is not run over explainers/code, and ten of those files have lint errors

2 participants