Skip to content

feat: report benchmark progress - #1219

Merged
yakew7 merged 1 commit into
yakew7:mainfrom
dxnnystyles:feat/issue-1204-benchmark-progress
Oct 29, 2026
Merged

yakew7 merged 1 commit into
yakew7:mainfrom
dxnnystyles:feat/issue-1204-benchmark-progress

Conversation

@dxnnystyles

Copy link
Copy Markdown
Contributor

Summary

adds per-combination benchmark progress on stderr, with --quiet to suppress progress while keeping warnings and the final summary available.

Type

  • Audit
  • Explainer
  • Bug fix
  • Other

Audit checklist

  • I opened or linked a corresponding issue first — N/A (not an audit contribution)
  • The folder is named after the domain, not the dataset — N/A (not an audit contribution)
  • unfair.py includes protected attributes and prints the required output format — N/A (not an audit contribution)
  • fair.py removes protected attributes and identified proxy variables — N/A (not an audit contribution)
  • Both scripts use random_state=42 and an 80/20 train/test split — N/A (not an audit contribution)
  • Proxy variables were actually tested, not just guessed — N/A (not an audit contribution)
  • unfair.png and fair.png are included as PNG screenshots — N/A (not an audit contribution)
  • The dataset is public and accessible without login or payment — N/A (not an audit contribution)
  • The dataset file is included, or DATA.md is included if the file is too large — N/A (not an audit contribution)
  • README.md includes the new results row and audit section — N/A (not an audit contribution)
  • A notebook was added if the audit benefits from one — N/A (not an audit contribution)

Before fairness gap: N/A (not an audit contribution)

After fairness gap: N/A (not an audit contribution)

Reduction: N/A (not an audit contribution)

Protected attribute(s): N/A (not an audit contribution)

Proxy variables dropped: N/A (not an audit contribution)


Explainer checklist

  • The file is in explainers/ and uses lowercase hyphenated naming — N/A (not an explainer contribution)
  • It includes a plain-language definition — N/A (not an explainer contribution)
  • It uses a real example from this repo or a documented real-world case — N/A (not an explainer contribution)
  • It includes runnable Python detection or measurement code — N/A (not an explainer contribution)
  • It acknowledges limitations or trade-offs — N/A (not an explainer contribution)
  • It links to related explainers or repo projects — N/A (not an explainer contribution)
  • It includes 2-3 primary sources — N/A (not an explainer contribution)
  • The Explainers table in README.md was updated — N/A (not an explainer contribution)

Linked issue

Closes #1204

Verification

  • Focused benchmark progress tests — passed (3 tests)
  • Focused --quiet CLI check — passed; progress suppressed, warning and final summary retained
  • make test-fast — passed (1,201 passed, 33 skipped, 27 deselected)
  • make lint — passed, including contributor recognition
  • git diff --check — passed
  • Hosted Actions and the slower test suite — not run locally

@github-actions

Copy link
Copy Markdown

@yakew7 @Shreyash0712 @ahmdkaml - new PR touching a path you own, please review.

@vercel

vercel Bot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

@dxnnystyles is attempting to deploy a commit to the yashkewlani2020-gmailcom's projects Team on Vercel.

A member of the Team first needs to authorize it.

@yakew7
yakew7 merged commit fa1eb4e into yakew7:main Oct 29, 2026
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The benchmark prints no progress during a run that takes tens of minutes

2 participants