Fixed lost onPartitionSessionClosed event#649
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses a missing onPartitionSessionClosed callback for force (non-graceful) StopPartitionSessionRequest handling in the Topic read session implementation, and adds an integration test that exercises changefeed consumption and validates the close event delivery.
Changes:
- Emit
onPartitionSessionClosedfor force-stopped partition sessions inReadSession. - Add a new changefeed integration test that validates partition session lifecycle events, including close.
- Add the Table SDK as a test-scoped dependency for the topic module to support the new integration test.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| topic/src/main/java/tech/ydb/topic/read/impl/ReadSession.java | Calls handleClosePartitionSession when receiving a force stop request so onPartitionSessionClosed isn’t skipped. |
| topic/src/test/java/tech/ydb/topic/ChangefeedTopicTest.java | New integration test covering changefeed reads and verifying partition session close events and reader close ordering. |
| topic/src/test/java/tech/ydb/topic/TopicReadersIntegrationTest.java | Cleans up unused imports/reorders imports (no functional change). |
| topic/pom.xml | Adds ydb-sdk-table as a test dependency to compile/run the new changefeed test. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #649 +/- ##
============================================
+ Coverage 71.09% 71.29% +0.19%
- Complexity 3358 3365 +7
============================================
Files 379 379
Lines 15915 15916 +1
Branches 1669 1669
============================================
+ Hits 11315 11347 +32
+ Misses 3955 3917 -38
- Partials 645 652 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@alex268 Please set up your personal token, see instructions: https://nda.ya.ru/t/dur-L1y77biDC2 |
No description provided.