Repository navigation
Ignore unreachable nodes when detecting the local DC - #777
Merged
Merged
Conversation
A failed TCP probe returns Long.MAX_VALUE and detectLocalDC summed it with the other probes of the datacenter. The sum overflowed into a negative value, so a datacenter with an unreachable node - or with two of them - got the lowest average ping and was picked as the local one: e.g. probes of [1ms, unreachable] average to -4611686018426887904. Average only the successful probes and skip a datacenter whose probed nodes are all unreachable. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #777 +/- ##
============================================
+ Coverage 75.47% 75.67% +0.19%
- Complexity 3755 3765 +10
============================================
Files 396 396
Lines 16842 16861 +19
Branches 1780 1780
============================================
+ Hits 12711 12759 +48
+ Misses 3515 3487 -28
+ Partials 616 615 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
KirillKurdyukov
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update for #764