fix(skills): make the zi-install loader probe positive - #638
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The probe mishandles relative XDG paths and does not verify cleanup of all loader helpers.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 2
Open (2)
What changed in this PR
Updates Zi Loader verification to exercise init.zsh directly and validate zzinit cleanup.
Changes:
- Adds a clean-shell Loader probe with explicit diagnostics.
- Separates Loader verification from install-only verification.
| File | Description |
|---|---|
.github/skills/zi-install/SKILL.md |
Strengthens post-install Loader verification. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ss-o
force-pushed
the
fix/zi-install-loader-probe
branch
from
September 19, 2026 04:14
2e0a08e to
eb128ed
Compare
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The probe can still accept a pre-existing zzinit, and the linked pilot remains pinned to the old probe.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 2
Open (2)
Resolved since last review (2)
`zzinit:0` after an interactive shell was also true when init.zsh was never sourced, so a pre-existing integration could pass Loader verification without exercising the installed loader. The probe now sources the resolved init.zsh in a clean shell, requires zzinit to be defined by that source, runs it, and requires it to remove itself. Refs #636
ss-o
force-pushed
the
fix/zi-install-loader-probe
branch
from
September 19, 2026 04:18
eb128ed to
96508fa
Compare
ss-o
added a commit
to z-shell/src
that referenced
this pull request
Sep 19, 2026
z-shell/.github#638 replaced the Loader verification with a positive probe; pin the delivery to its squash commit de88a85250897123602f3586ca7861cac782bc4b.
This was referenced Sep 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/skills/zi-install/SKILL.md: the Loader verification probe is now positive evidence. It sources the resolvedinit.zshin a cleanzsh -fshell, requireszzinitto be defined by that source, runs it, and requires it to remove itself; each failure prints its own line. The previouszzinit:0check after an interactive shell was also satisfied wheninit.zshhad never been sourced, so a pre-existing integration could pass Loader verification without exercising the installed loader (raised by Copilot on the src pilot delivery, chore(agents): install the zi-install skill src#216).Refs #636
Verification
public/zsh/init.zshfromz-shell/srcmainwith a stand-inzi.zsh: printsloader okwhen the loader is present andloader missingwith exit 1 when it is not.python3 scripts/validate-agent-policy.pypasses; no manifest change, the surface already exists.Instruction impact review (
runbooks/instruction-update.md)Agent handoff
No handoff needed.