feat(routing): align guided setup architecture and skill - #649
Conversation
There was a problem hiding this comment.
Fallback review under ADR-0026: Copilot request not registered on a4613c7
No findings.
Reviewed the complete three-file diff against AGENTS.md, the instruction-update runbook, ADR-0025, and the canonical code-review guidance. The implementation keeps one canonical decision file, constrains the new route to the four planner paths, rejects exact duplicate selector sets, and requires shared-file kind, authority, and review-owner metadata to agree.
Evidence: clean-snapshot policy validation passed; all 92 policy tests and 17 decision-record tests passed; Trunk passed; hosted Agent Instruction Validation, commit policy, and CodeQL checks passed.
Residual evidence gap: the new route was not independently exercised through each supported runtime discovery mechanism. Runtime-generated workspace carriers were excluded from the standalone-clone validation because they are not repository content.
Summary
setup.zshentrypointzi-installskillInstruction impact review
setup.zshentrypoint..github/skills/zi-install/SKILL.mdowns operational installation guidance..zshrcblock.Traceability
Refs z-shell/src#208 and z-shell/src#221.