Conversation
The burst runs the just-written recipe in `zsh -f -c`; sourcing a file that ends with `zicompinit` makes compinit abort without a terminal, so the burst returned non-zero after every annex had been installed and the installer printed the "next shell start" fallback (first real CI run, #212). Write only the `zi light-mode for ...` recipe to the burst file and append `zicompinit` to .zshrc alone. The zsh test double now refuses a sourced file that contains zicompinit, and the annex case asserts that .zshrc still receives it. Closes #213
Deploying src with
|
| Latest commit: |
b2273df
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://fcaa5afd.zi-src.pages.dev |
| Branch Preview URL: | https://bug-213.zi-src.pages.dev |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The new assertion can pass without verifying that the annex-specific block writes zicompinit.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Separates zicompinit from the non-interactive annex burst while preserving .zshrc configuration.
Changes:
- Limits the burst file to the annex recipe.
- Adds a test-double guard against sourcing
zicompinit. - Regenerates the installer checksum.
| File | Description |
|---|---|
public/sh/install.sh |
Moves zicompinit outside the burst fragment. |
tests/installers.sh |
Tests burst isolation and .zshrc output. |
public/checksum.txt |
Updates the installer checksum. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ANNEX_PROFILE: the burst file now holds only thezi light-mode for ...recipe; for-a annexthezicompinitline (and its example comment) is appended to.zshrcdirectly, so the non-interactive burst never sources it. The first real CI run (ci(installer): run each install profile for real and fail the step when it fails #212, Linux) showedcompinit: initialization abortedafter all annexes had installed, which turned a successful burst into the "next shell start" fallback.zshdouble refuses any sourced file containingzicompinit, and the annex case asserts.zshrcstill receives it.Closes #213
Verification
sh ./tests/installers.sh: 30 cases pass on the committed tree;shellcheck -s shclean;public/checksum.txtregenerated after the commit hook formatted the file.Check (Linux)annex step is the real evidence: reviewed for the absence of the fallback line before merge.Agent handoff
No handoff needed.