Normalize integer scalar keepbits in BitRound#851
Draft
sapunyangkut wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
keepbitsvalues withoperator.indexbefore BitRound arithmeticint32, and NumPyint64scalars plus invalid inputsFixes #793.
Validation
tests/test_bitround.py: 16 passedint, negative NumPy integers raiseValueError, and floats raiseTypeErrorpython -m compileall -q src/numcodecs/bitround.py tests/test_bitround.pygit diff --checkThe focused tests loaded the repository's Python modules directly because this Windows environment does not have the project's compiled C extensions and build toolchain. The full suite, documentation build, and coverage run were not executed locally; this remains a Draft while CI and maintainer review provide those gates.
Checklist
docs/release.mdAI assistance disclosure
This patch, tests, and pull request text were developed and checked with OpenAI Codex assistance. No independent human self-review is claimed; maintainer review is requested before merge.