chore(metadata): import Literal at module level in v2.py - #4327
Open
d-v-b wants to merge 2 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4327 +/- ##
==========================================
- Coverage 94.30% 94.30% -0.01%
==========================================
Files 92 92
Lines 12912 12911 -1
==========================================
- Hits 12177 12176 -1
Misses 735 735
🚀 New features to boost your workflow:
|
parse_zarr_format needs Literal at runtime for its parse_field type argument, so zarr-developers#4063 added a function-local import next to the existing TYPE_CHECKING one. Import it once at module level like the other modules that commit touched. The docstring and depth-limit corrections this branch originally carried are superseded by zarr-developers#4330, which removes the attribute depth limit and the validate_json_value helper entirely. Assisted-by: ClaudeCode:claude-fable-5-1
d-v-b
force-pushed
the
chore/json-parse-cleanups
branch
from
September 9, 2026 13:21
b59d7a7 to
1636969
Compare
d-v-b
changed the title
github-actions
Bot
added
the
needs release notes
d-v-b
marked this pull request as ready for review
September 9, 2026 13:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI-written PR that makes imports happen more correctly. Self-merging when green.
🤖 AI text below 🤖
Summary
A leftover from #4063:
src/zarr/core/metadata/v2.pyimportedLiteralunderTYPE_CHECKINGand then again insideparse_zarr_formatat call time, because the function uses it at runtime for theparse_fieldtype argument. Move it to the module-leveltypingimport like every other module touched by #4063.This PR originally also corrected the
json_parsemodule docstring and the off-by-one boundary of the attribute nesting-depth limit. #4330 removes that limit (and thevalidate_json_valuehelper) altogether, which makes those changes moot, so they have been dropped here; only the import move remains. No changelog fragment is needed for an import move.Found during the pre-release review for #4256.
For reviewers
A three-hunk import move with no behavior change. If #4330 lands first this still applies cleanly; the two PRs no longer touch the same lines.
Author attestation
TODO
docs/user-guide/*.md(n/a)changes/(n/a — import move)