refresh() overhaul - #38
Draft
ze2j wants to merge 9 commits into
Draft
Conversation
refresh() read pane geometry from two places: the pane nodes for change detection and the axis titles, and PaneStack.compute_child_rects() for the layout. The two disagree while a resize is pending, a stale layout could survive unnoticed. Everything now reads the rects the stack is about to apply. Axis title insets take the rects and the stack global position instead of the pane nodes.
The refresh read pane sizes that Godot had not updated yet, so the plot kept the geometry of its previous size after a resize. The pane stack now computes the layout itself, inside its sort, which is the first moment the real sizes exist. The refresh only prepares the styles and the domain, then asks for a sort. Nothing outside the sort reads a pane size or position any more.
XYAxisConfigSnapshot will be dropped once each config class has its tracker.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix #37
Testing
Run all tests.
AI disclosure
Initial implementation + code comments. Design and final implementation are mine.