ci check: test_runner Temporal.Now mocking - #1
Closed
zeexzeex wants to merge 4 commits into
Closed
Conversation
Draft documentation for nodejs#63369. The pr-url placeholder must be replaced once the pull request is opened. Refs: nodejs#63369 Signed-off-by: Avocado <ujubongbong@gmail.com>
Signed-off-by: Renegade334 <contact.9a5d6388@renegade334.me.uk> Signed-off-by: Avocado <ujubongbong@gmail.com>
Signed-off-by: Avocado <ujubongbong@gmail.com>
Add a 'Temporal.Now' token to mock.timers.enable({ apis }). The mocked
instant(), zonedDateTimeISO(), plainDateTimeISO(), plainDateISO() and
plainTimeISO() methods are backed by the same internal mock clock as
Date. timeZoneId() is not mocked. Mocked values are constructed through
the internal Temporal utils so they are not affected by user
modifications to the global Temporal object.
Fixes: nodejs#63369
Refs: nodejs#63312
Signed-off-by: Avocado <ujubongbong@gmail.com>
zeexzeex
force-pushed
the
mock-timers-temporal
branch
from
August 14, 2026 02:49
8a56b70 to
75c6b8d
Compare
Owner
Author
|
CI pre-check finished: all build and test jobs passed on linux x64/arm64, macOS and windows coverage. The only failure is the known pr-url REPLACEME placeholder in doc/api/test.md, to be filled once the real PR is opened. Closing as planned. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI pre-check for the MockTimers Temporal.Now work (nodejs#63369).
Includes the commits from nodejs#63312 as a prerequisite. Will be closed after the checks finish. Not intended for merging.