(feat) Add Turbopuffer namespace pinning CLI#773
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jamesgao-jpg The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
e2c51da to
8b9ee54
Compare
|
@jamesgao-jpg I'm not very familiar with VectorDBBench internals, just in case :) Nevertheless, this |
I've pondered about where to document this, at the end I can't think of a better location than where the code currently lies, since this is a rather niche thing with turbopuffer (they allow users to pin certain namespace for indefinite duration for more predictable performance). |
|
@jamesgao-jpg Please ensure that this is properly documented in readme.md on the https://github.com/zilliztech/VectorDBBench. Also, can this be implemented as a flag to plain Turbopuffer instead of a separate benchmark? I'm not saying whether this is needed to be implemented this way, but I'm asking to confirm the decision. |

Summary
--pin-namespace/--no-pin-namespaceand--pin-replicasto the Turbopuffer benchmark CLI.TurboPufferUnpinCLI command to clear namespace pinning after benchmark runs.Test Plan
python -m py_compile vectordb_bench/backend/clients/turbopuffer/cli.py vectordb_bench/backend/clients/turbopuffer/config.py vectordb_bench/backend/clients/turbopuffer/turbopuffer.py vectordb_bench/cli/vectordbbench.py{"pinning": null}), no real Turbopuffer API calls made.Notes