Keep Memory locals as Memory in iterators - #114
Merged
Merged
Conversation
A Memory local in an iterator may have to hold its value across a yield return, which a span can't, so it is no longer declared as a span there. A Memory local passed to a call which isn't being synchronized keeps its type too, rather than having .Span appended, since that call still takes the Memory it took before. Corrects the snapshot for zompinc#113's test, which expected .Span to be passed to a method taking ReadOnlyMemory. Generated with Claude Code
Contributor
|
Rebased onto master and added the fix: a Memory local now stays Memory in an iterator, and |
virzak
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #113