Check that every test input clones without changes - #169
Merged
Merged
Conversation
Every test now also runs an identity transformation over its source: IdentityCloneGenerator copies each method the sync generator would synchronize through IdentityRewriter, a CloningRewriter which changes nothing but the method's name, and the test fails if a copy does not compile. A failure there is in the Cloning layer - qualification, usings, containing types, directives - rather than in the async to sync rules, which the snapshot tests cannot tell apart. The pass also fails when it clones fewer methods than were synchronized, so that cloning nothing cannot pass for cloning correctly. The generator exposes its internals to Generator.Tests for this. Generated with Claude Code
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #169 +/- ##
==========================================
+ Coverage 92.26% 92.37% +0.11%
==========================================
Files 15 15
Lines 1706 1706
Branches 391 391
==========================================
+ Hits 1574 1576 +2
+ Misses 48 46 -2
Partials 84 84 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every test now also clones each method it synchronizes through
IdentityRewriter, aCloningRewriterthat only renames the method, and fails with "Identity clone does not compile" if a clone doesn't. That separates bugs in theCloning/layer from bugs in the async to sync rules. No existing input fails and no snapshot changes.The pass also fails if it clones fewer methods than were synchronized, so cloning nothing can't pass. The generator gets
InternalsVisibleToforGenerator.Tests.Generated with Claude Code