Repository navigation
fix: portal auth setting - #7819
Merged
Merged
Conversation
shaohuzhang1
commented
Nov 10, 2026
| <el-input-number v-model="authForm.failed_attempts" class="w-32!" :min="-1" :max="100" :precision="0" :value-on-clear="5" /> | ||
| <span class="shrink-0">次,锁定账号</span> | ||
| <el-input-number v-model="authForm.lock_time" class="w-32!" :min="1" :max="1440" :precision="0" :value-on-clear="10" /> | ||
| <span class="shrink-0">分钟</span> |
Contributor
Author
There was a problem hiding this comment.
Here is a concise review of the code change:
Issue: Logical/Security Flaw
min="-1"allows negative values:failed_attemptsrepresents a count of failures. Allowing-1(or any negative number) is meaningless and logically incorrect for this field. It could lead to unexpected behavior in backend logic (e.g., if the system checksattempts >= threshold, a negative value might bypass lockouts incorrectly or cause calculation errors).
Recommendation:
- Revert to
:min="0"(or1if zero failures shouldn't be stored). Negative values are not valid for a "failure counter." - If the intent was to allow clearing/resetting via the UI, use
value-on-clearappropriately, but keepminnon-negative.
Additional Suggestion:
- Ensure the UI text ("Login failed... times") clearly indicates that this is a threshold for locking account, not the current attempt count. If it's the threshold,
min="1"is safer because locking after 0 failures makes no sense.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
【【门户访问设置】登录设置的登录失败N次锁定账号,N无法设置为 -1】
https://www.tapd.cn/tapd_fe/45245355/bug/detail/1145245355001079125