Skip to content

fix: portal auth setting #7819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fit2cloudwxx merged 1 commit into from
Nov 10, 2026
Merged

fix: portal auth setting #7819

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ui/src/views/system/chat-management/portal-setting/components/ButtonPortalAuthSetting.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ defineExpose({ open })
</div>
<div class="flex-align-center gap-2">
<span class="shrink-0">登录失败</span>
<el-input-number v-model="authForm.failed_attempts" class="w-32!" :min="1" :max="100" :precision="0" :value-on-clear="5" />
<el-input-number v-model="authForm.failed_attempts" class="w-32!" :min="-1" :max="100" :precision="0" :value-on-clear="5" />
<span class="shrink-0">次，锁定账号</span>
<el-input-number v-model="authForm.lock_time" class="w-32!" :min="1" :max="1440" :precision="0" :value-on-clear="10" />
<span class="shrink-0">分钟</span>

@shaohuzhang1 shaohuzhang1 Nov 10, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is a concise review of the code change:

Issue: Logical/Security Flaw

  • min="-1" allows negative values: failed_attempts represents a count of failures. Allowing -1 (or any negative number) is meaningless and logically incorrect for this field. It could lead to unexpected behavior in backend logic (e.g., if the system checks attempts >= threshold, a negative value might bypass lockouts incorrectly or cause calculation errors).

Recommendation:

  • Revert to :min="0" (or 1 if zero failures shouldn't be stored). Negative values are not valid for a "failure counter."
  • If the intent was to allow clearing/resetting via the UI, use value-on-clear appropriately, but keep min non-negative.

Additional Suggestion:

  • Ensure the UI text ("Login failed... times") clearly indicates that this is a threshold for locking account, not the current attempt count. If it's the threshold, min="1" is safer because locking after 0 failures makes no sense.

Expand Down
Loading