feat(color): Use inactive color spaces in the OCIO config - #5387
Open
brechtvl wants to merge 1 commit into
Open
Conversation
…onfig In older ACES configs, like v2.1.0 bundled with OpenColorIO 2.3, the display color spaces are inactive. This meant they could not be looked up or converted to, even when specifying their exact name. Now include inactive color spaces in the list, and add isColorSpaceActive() to test if a colorspace is active. Inactive color spaces remain hidden from the user interface in iv. Signed-off-by: Brecht Van Lommel <brecht@blender.org>
30 tasks
Collaborator
|
LGTM, would like double check from @zachlewis |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In older ACES configs, like v2.1.0 bundled with OpenColorIO 2.3, the display color spaces are inactive. This meant they could not be looked up or converted to, even when specifying their exact name.
Now include inactive color spaces in the list, and add
isColorSpaceActive()to test if a colorspace is active. Inactive color spaces remain hidden from the user interface in iv.Ref #4980
Tests
Test output now includes these inactive color spaces.
Checklist:
and if I used AI coding assistants, I have an
Assisted-by: TOOL / MODELline in the pull request description above.
behavior.
PR, by pushing the changes to my fork and seeing that the automated CI
passed there. (Exceptions: If most tests pass and you can't figure out why
the remaining ones fail, it's ok to submit the PR and ask for help. Or if
any failures seem entirely unrelated to your change; sometimes things break
on the GitHub runners.)
fixed any problems reported by the clang-format CI test.
corresponding Python bindings. If altering ImageBufAlgo functions, I also
exposed the new functionality as oiiotool options.