Repository navigation
chore: Ignore some unmaintained dependencies of zbus - #834
Merged
Merged
Conversation
|
Out of curiousity as a downstream lib, what's accesskit's MSRV policy? I see you're on 1.87 on main currently, but I'm always interested in the rationale and strategy for more conservative approaches to MSRV. |
Member
Author
|
There's no formal policy at the moment. We were just following winit for a while but since it's not moving much these days I'm checking what our users are doing. Servo was on 1.87 when I bumped it recently. I think we were overly conservative in the past but I don't want to require latest stable either. |
stuartparmenter
added a commit
to stuartparmenter/bevy
that referenced
this pull request
Oct 20, 2026
# Objective Fix the failing `check-advisories` CI check. ## Solution Ignore three maintenance advisories for `zvariant`, `zbus_names`, and `zvariant_derive`, which were [merged into zbus 6](z-galaxy/zbus#2043), matching [AccessKit’s upstream fix](AccessKit/accesskit#834). These crates are pulled in through `bevy_winit → accesskit_winit → accesskit_unix → AT-SPI / zbus`. The latest AccessKit and AT-SPI releases still depend on zbus 5. AccessKit cannot upgrade yet because zbus 6 requires Rust 1.89. Removing these exceptions will require upstream migrations and an update to Bevy’s Linux game-mode integration, which also depends directly on zbus and uses its removed blocking API. ## Testing `cargo deny check advisories` no longer reports these three advisories. ## AI Disclosure Used Codex to investigate CI logs and upstream dependencies and add the advisory exceptions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These crates have been merged into zbus and their author has decided to publish advisories for them. zbus 6.0 has an MSRV of 1.89 so we can't upgrade quite yet. Ignores these advisories for now. cargo-deny will still notify us if other security advisories are published for these crates.