Repository navigation
lance 13 / arrow 58 / datafusion 54 - #180
Merged
Merged
Conversation
…led) lance 2.0 -> 13.*, arrow* / parquet / arrow-flight 57 -> 58, datafusion 51 -> 54, sqlparser 0.60 -> 0.62 (datafusion-sql 54's). datafusion is taken with default features minus `compression`: that feature links `lzma` via liblzma, while the n8n vendor crates (datafusion 51) link it via xz2, and cargo allows one `links = "lzma"` per graph. lance 13 does not enable it either. No arrow type crosses the n8n boundary (only n8n_grpc's string/bytes handlers), so arrow 57 and 58 coexist. The graph resolves (cargo metadata); compile + tests follow. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017YPZhKpSxN7eSxk7VH2vzB
DataFusion 54 removes `as_any` from ScalarUDFImpl, ExecutionPlan and
TableProvider (they take `Any` as a supertrait now) and changes
`ExecutionPlan::properties` to return `&Arc<PlanProperties>`. The plan
structs in query/{dn_tree_provider,fingerprint_table,graph_provider,
scent_scan}.rs store `Arc<PlanProperties>`; the 22 `as_any` impls and
their now-unused `std::any::Any` imports are removed.
The lance 13 storage code (storage/lance*.rs, query/datafusion.rs)
compiled unchanged. `cargo +1.99.0 check --all-targets`: the lib and
lib tests compile; the one remaining error is pre-existing on main
(tests/proof_level_a_gaps.rs imports `ladybug::core::simd`, which does
not exist there either).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017YPZhKpSxN7eSxk7VH2vzB
AdaWorldAPI
marked this pull request as ready for review
October 10, 2026 08:39
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Lance 13's lance-encoding compiles .proto files in its build script and needs protoc plus the well-known includes. The Dockerfiles already install protobuf-compiler; the proof and ci-master workflows did not, so Compile Check failed with 'Could not find protoc'. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017YPZhKpSxN7eSxk7VH2vzB
core::simd was removed in ced28ba but this proof still imported core::simd::{hamming_distance, hamming_scalar}, so the test target did not compile (on main too). Import the live core::hamming_distance and keep the scalar reference as a local test oracle (popcount of word-wise XOR). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017YPZhKpSxN7eSxk7VH2vzB
Owner
Author
|
CI status on
Unit Tests (all modules) is still red, but those failures are not caused by this PR:
Fixing the 27 failing tests that Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This moves ladybug-rs onto the workspace's lance 13 line. It is the migration the manifest comment from 2026-09-25 says "lands together with that migration, never alone".
lance2.0 →13.*arrow*,parquetandarrow-flight57 → 58datafusion51 → 54sqlparser0.60 → 0.62 (the versiondatafusion-sql54 uses)lzmalink conflict: cargo allows only one package per build to link the nativelzmalibrary. The n8n vendor crates (datafusion 51) link it throughxz2, and datafusion 54's defaultcompressionfeature links it throughliblzma. I took datafusion 54 with its default features minuscompression. ladybug never reads compressed files through DataFusion, and lance 13 doesn't enablecompressioneither.n8n_grpc::handle_api_{post,get}, which take strings and bytes. So cargo builds both arrow lines side by side.storage/lance*.rsandquery/datafusion.rscompiled unchanged.query/{cognitive_udfs,dn_tree_provider,fingerprint_table,graph_provider,scent_scan}.rs:as_anywas removed fromScalarUDFImpl,ExecutionPlanandTableProvider(they now takeAnyas a supertrait). I removed the 22 impls and thestd::any::Anyimports they left unused.ExecutionPlan::propertiesnow returns&Arc<PlanProperties>, so the four plan structs storeArc<PlanProperties>.Test plan
Rust 1.99, debug info off.
cargo test --libon this branch and onmain(lance 2.0 / DF 51), run withRUST_MIN_STACK=64MiB; with the default stack, both runs abort part-way with a stack overflow, also onmain.mainquery::dn_tree_provider::tests::test_dn_tree_provider_with_data, panics atstorage/bind_space.rs:451onmainas well.cargo check --all-targets: the library and lib tests compile.tests/proof_level_a_gaps.rsdoes not compile because it importsladybug::core::simd, which does not exist onmaineither.The first commit's message says "WIP / not yet compiled". That was its state when pushed; the second commit completes the port, and everything above was verified on the final head.
🤖 Generated with Claude Code
https://claude.ai/code/session_017YPZhKpSxN7eSxk7VH2vzB
Generated by Claude Code