Skip to content

glove-parity: refuse two populations of one relation target concept (#1514 follow-up) - #1516

Merged
AdaWorldAPI merged 2 commits into
mainfrom
ccr-9f3b8075-74u47l-rel2
Oct 12, 2026
Merged

AdaWorldAPI merged 2 commits into
mainfrom
ccr-9f3b8075-74u47l-rel2

Conversation

@AdaWorldAPI

Copy link
Copy Markdown
Owner

What

This carries the Codex finding on #1514 into main. The fix (74f4be9) was pushed seconds after #1514 merged, so it never landed.

The bug: a method can read two relations whose targets are the same concept in different populations. Preparation kept only the first population. A call that named that population passed the check, but the program still read the second relation's planes, so data from two populations could mix.

The fix: preparation now refuses the method with PrepareError::ConflictingUniverse(concept). A call names one population per concept, so the conflict can't be resolved at call time and is refused up front.

Evidence

  • New test two_populations_of_one_target_concept_are_refused, with a silence twin: the same population reached through both relations still prepares.
  • Before the fix the test failed: the method prepared and kept only universe 8.
  • Disabling the check turns it red again.
  • tests/relation.rs passes 8/8; the crate's full suite and clippy (-D warnings) were green when the fix commit was made, and clippy is clean again on this branch.

Board

🤖 Generated with Claude Code

https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh


Generated by Claude Code

A call names one population per target concept, so a method whose two
relations reach the same concept in different universes cannot say which
one each relation reads. Preparation now refuses it (ConflictingUniverse)
instead of keeping the first. Codex review on #1514.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh
@coderabbitai

coderabbitai Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

Next included review available in 50 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available. Your 62 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 571c273e-b70e-4ed5-ad91-6ad6eca196a0

📥 Commits

Reviewing files that changed from the base of the PR and between 10325b3 and d746905.


📒 Files selected for processing (4)
  • .claude/board/STATUS_BOARD.md
  • .claude/plans/gremlin-composable-algebra-v1.md
  • crates/lance-graph-glove-parity/src/method.rs
  • crates/lance-graph-glove-parity/tests/relation.rs

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption.


Comment @coderabbitai help to get the list of available commands.

@AdaWorldAPI
AdaWorldAPI marked this pull request as ready for review October 12, 2026 19:33
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-12T19:34:27.365638Z d746905 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@AdaWorldAPI
AdaWorldAPI merged commit c1ce262 into main Oct 12, 2026
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants