Repository navigation
board: #1529 merged (D-PROD-V4) - #1530
Conversation
…RD row Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh
|
Warning Review limit reachedYour organization has reached its usage spending cap. Adjust your spending cap in the billing tab. Next included review available in 31 minutes. View limit details
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c76b8bc4a2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ## 2026-10-13 — lance-graph PR #1529 (merged `2d33bb0`, branch `ccr-9f3b8075-74u47l-prod-v4`, head `6197dac`, 13 commits) — D-PROD-V4: production build tiers | ||
|
|
||
| - **Added:** shipped builds leave v3. `Dockerfile.avx512` (canonical deploy) builds `sapphirerapids`; plain `Dockerfile` (fallback) builds `native`; `Dockerfile.hhtld`, `crates/cognitive-stack/Dockerfile`, `crates/symbiont/Dockerfile` copy the new `.cargo/config-v4.toml`; both thinking-engine images and `make publish` build `x86-64-v4`. `build.yml` gains `linux-build-v4`, a compile-only matrix over `x86-64-v4` and `sapphirerapids` (nothing runs; most runners are v3), debug 0 for every artifact. The two root Dockerfiles now clone ndarray and OGAR at their default branches and copy `tools/`; before, they could not resolve the workspace. Also carries #1525's board entries. | ||
| - **Locked:** every v4/Sapphire Rapids build that runs build scripts on a possibly older host passes `--target <host triple>`, so the CPU flags reach only target artifacts (codex P1, coderabbit). Measured on a scratch crate: without `--target` the build script compiled with `target-cpu=x86-64-v4` and `-C debuginfo=2`; with it, neither. AMD: v4 covers Zen 4/5 completely; `sapphirerapids` lacks only `avx512fp16` there (and `avxvnni` on Zen 4); Zen 3 has no AVX-512 (`rustc --print cfg`). |
There was a problem hiding this comment.
--target coverage that the images lack
The two thinking-engine images contradict this locked invariant: crates/thinking-engine/Dockerfile sets CARGO_TARGET_X86_64_UNKNOWN_LINUX_GNU_RUSTFLAGS at line 5 but invokes Cargo without --target at line 32, and Dockerfile.railway does the same at lines 13 and 25. Cargo explicitly documents that without --target, rustflags reach build scripts and proc macros, so building either v4 image on an older host can still compile and execute host tools with v4 instructions and fail with SIGILL. Either add the host triple to those builds or record these images as exceptions rather than locking the claim that every such build is scoped.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Correct, #1529 missed both thinking-engine images. Fixed in 2d67e54: both now build with --target <host triple> and copy the binary back to the path the runtime stage reads. Running that line in a Docker-shaped layout turned up three earlier breaks, fixed in the same commit: no ndarray sibling clone, a rust:1.98.1 base against the 1.99 toolchain, and no --example playground even though the runtime stage copies that example. The Railway image also had 2>/dev/null || true, which hid all three. Verified: the build finishes with the image's v4 flags, and the binary is where COPY reads it. The PR_ARC entry now records the gap and the fix.
Generated by Claude Code
… rust 1.99, build the copied example codex P2 on #1530: both images set the v4 flags but invoked cargo without --target, so build scripts and proc-macros were compiled for v4 and run on the build host. Building the new line in a Docker-shaped layout also showed three earlier breaks: no ndarray sibling, a 1.98.1 base image against the 1.99 toolchain, and no playground example built for the COPY. The Railway image's '2>/dev/null || true' hid all of them. PR_ARC entry for #1529 records the gap and the fix. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh
…hain.toml ndarray, p64 and thinking-engine declare rust-version 1.99.0; a 1.98.1 builder refuses them (measured on the thinking-engine image in #1530). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh
2 participants
Board entries for #1529 (D-PROD-V4), which merged before its board entries could land.
PR_ARC_INVENTORY.md: build: production targets x86-64-v4 (D-PROD-V4) #1529 entry (Added / Locked / Deferred / Confidence). It records the open items: nodocker buildrun, the test jobs still on a v3 pin, symbiont and cognitive-stack cloning ndarray from a feature branch, the Railway healthcheck question, and thatlinux-build-v4's first full run is themainpush run.LATEST_STATE.md: build: production targets x86-64-v4 (D-PROD-V4) #1529 moved from "open" to "on main".STATUS_BOARD.md: new D-PROD-V4 row, status Shipped.Hygiene only: under the termination clause this PR gets no arc entry of its own. Entries index
--checkandappend_only_gatepass;SUPERSESSION-INDEX.mdregenerated (unchanged).🤖 Generated with Claude Code
https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh
Generated by Claude Code