Repository navigation
core: depend on the fold path (D-FOLD-CORE-b) - #1537
Conversation
crates/lance-graph depends on lance-graph-mask-risc, -quack and -r2il unconditionally and re-exports them as lance_graph::fold. No wrapper, no second algebra: a missing capability is missing in one of the three crates. tests/fold_path.rs runs a Quack query (two row ranges intersected plus a value predicate) and an R2IL count through core, each against a row loop. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
D-FOLD-CORE-b: core
lance-graphdepends on the fold path.What changes
crates/lance-graphdepends onlance-graph-mask-risc,lance-graph-quackandlance-graph-r2ilunconditionally. There is no feature gate, because the polyfill is part of core.lance_graph::foldre-exports the three crates asmask_risc,quackandr2il. Core adds no wrapper and no second algebra, so a missing capability is missing in one of the three crates.tests/fold_path.rsruns two queries through core:Each result is checked against a plain row loop.
Verified
cannot find fold in lance_graph). After it, 2/2 pass.cargo clippy --manifest-path crates/lance-graph/Cargo.toml --lib --tests -- -D warnings(CI's line) is clean;cargo fmtis clean.cargo metadatashows one package each forlance-graph-contract,-mask-risc,-quack,-r2il,ogar-locoandogar-r2il. ndarray has two entries, the fork path plus 0.16.1 fromlance-index; both were there before this PR.Note
Cmp::Rangeis a range of rows on the ordered axis, not a value range. The first version of the test assumed value semantics and failed, which confirms the row-axis rule. The test now keeps the two kinds of condition apart: rows on the ordered axis are intersected, and the value predicate runs as a residual inside that range.Next: D-FOLD-CORE-c, NAL as a module of core.
🤖 Generated with Claude Code
https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh
Generated by Claude Code