Skip to content

core: depend on the fold path (D-FOLD-CORE-b) - #1537

Merged
AdaWorldAPI merged 2 commits into
mainfrom
ccr-9f3b8075-74u47l-core-fold
Oct 13, 2026
Merged

AdaWorldAPI merged 2 commits into
mainfrom
ccr-9f3b8075-74u47l-core-fold

Conversation

@AdaWorldAPI

Copy link
Copy Markdown
Owner

D-FOLD-CORE-b: core lance-graph depends on the fold path.

What changes

  • crates/lance-graph depends on lance-graph-mask-risc, lance-graph-quack and lance-graph-r2il unconditionally. There is no feature gate, because the polyfill is part of core.

  • lance_graph::fold re-exports the three crates as mask_risc, quack and r2il. Core adds no wrapper and no second algebra, so a missing capability is missing in one of the three crates.

  • tests/fold_path.rs runs two queries through core:

    • a Quack query: two row ranges intersected, plus a value predicate on a scattered lane;
    • an R2IL row-range count.

    Each result is checked against a plain row loop.

Verified

  • Test-first: before the change, the test failed to compile (cannot find fold in lance_graph). After it, 2/2 pass.
  • Disable run: dropping one of the two row ranges turns the Quack test red (303 vs 201).
  • cargo clippy --manifest-path crates/lance-graph/Cargo.toml --lib --tests -- -D warnings (CI's line) is clean; cargo fmt is clean.
  • cargo metadata shows one package each for lance-graph-contract, -mask-risc, -quack, -r2il, ogar-loco and ogar-r2il. ndarray has two entries, the fork path plus 0.16.1 from lance-index; both were there before this PR.

Note

Cmp::Range is a range of rows on the ordered axis, not a value range. The first version of the test assumed value semantics and failed, which confirms the row-axis rule. The test now keeps the two kinds of condition apart: rows on the ordered axis are intersected, and the value predicate runs as a residual inside that range.

Next: D-FOLD-CORE-c, NAL as a module of core.

🤖 Generated with Claude Code

https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh


Generated by Claude Code

crates/lance-graph depends on lance-graph-mask-risc, -quack and -r2il
unconditionally and re-exports them as lance_graph::fold. No wrapper, no
second algebra: a missing capability is missing in one of the three crates.

tests/fold_path.rs runs a Quack query (two row ranges intersected plus a
value predicate) and an R2IL count through core, each against a row loop.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh
@coderabbitai

coderabbitai Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: d5bea96d-5aa1-4ca8-ab21-63fa4f236bd0
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@AdaWorldAPI
AdaWorldAPI marked this pull request as ready for review October 13, 2026 17:25
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-13T17:26:54.040002Z 8091f98 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@AdaWorldAPI
AdaWorldAPI merged commit befbf1d into main Oct 13, 2026
12 checks passed
AdaWorldAPI added a commit that referenced this pull request Oct 13, 2026
…llowup

#1536 follow-up: pin ONA links, correct the supervisor backoff claim; board for #1536/#1537
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants