Skip to content

#1536 follow-up: pin ONA links, correct the supervisor backoff claim; board for #1536/#1537 - #1539

Merged
AdaWorldAPI merged 2 commits into
mainfrom
ccr-9f3b8075-74u47l-1536-followup
Oct 13, 2026
Merged

AdaWorldAPI merged 2 commits into
mainfrom
ccr-9f3b8075-74u47l-1536-followup

Conversation

@AdaWorldAPI

Copy link
Copy Markdown
Owner

#1536 merged with two open codex P2 findings. I've taken ownership of it; this PR resolves both and adds the missing board entries. Docs and board only.

Codex findings on #1536

  1. ONA links pinned. ONA_NAL_R2IL_FOLD_METHOD_ASSIMILATION.md named dc4efd0 as its oracle but linked blob/master/. All 12 source links now point at blob/dc4efd0abd520cdb79bf53bfa3c285ebb24f2e8a/, and the doc says why.

  2. Supervisor restart backoff. I checked supervisor.rs (the RespawnG arm and handle_supervisor_evt), and the finding is right. It also understates the problem:

    • The arm schedules a delayed RespawnG { crash_count: 0 } and then calls spawn_consumer_actor straight away.
    • The delayed message runs the same arm: it spawns immediately again and schedules another delayed message 100 ms later. This repeats forever, whether or not the child is alive.
    • The crash count is reset on every round, so the >10 escalation guard cannot trip.

    The doc row now says backoff is not applied. The defect is filed as ISS-SUPERVISOR-RESPAWN-BACKOFF-NOT-APPLIED in ISSUES.md, with what closes it. The code fix is not in this PR.

Board

W3 itself is in #1538.

🤖 Generated with Claude Code

https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh


Generated by Claude Code

… board for #1536/#1537

Takes over #1536 (merged with two open codex P2s):
- every ONA source link in the fold-method program points at the audited
  commit dc4efd0 instead of master;
- the outer-membrane note no longer lists restart backoff as implemented:
  the RespawnG arm spawns immediately and reschedules itself with a reset
  count, so no backoff is applied (ISS-SUPERVISOR-RESPAWN-BACKOFF-NOT-APPLIED).

Board: PR_ARC and LATEST_STATE for #1536 and #1537; D-FOLD-CORE-b shipped,
D-FOLD-CORE-c dropped (NAL stays its own crate).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh
@coderabbitai

coderabbitai Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 3ee21406-94e3-434b-8ecd-ecf00357b6a3
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@AdaWorldAPI
AdaWorldAPI marked this pull request as ready for review October 13, 2026 17:48
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-13T17:50:55.352024Z ab47ad2 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ab47ad2222

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .claude/board/STATUS_BOARD.md Outdated
D-FOLD-CORE-c was marked dropped with only the #1536 docs as the reason;
those docs describe lance-graph-nal as the starting contract but record no
decision. The decision came from the ONA assimilation brief of 2026-10-13.
Record it as a supersession note under the D-FOLD-CORE decision and point
the row and the #1536 arc entry at it (codex P2 on #1539).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh
@AdaWorldAPI
AdaWorldAPI merged commit 3635109 into main Oct 13, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants