Repository navigation
ci: compile both production tiers (x86-64-v4 and sapphirerapids) - #361
Conversation
tier4-avx512-check becomes a matrix over config-v4.toml and config-avx512.toml; both are compiled with cargo check and the asm-only codegen witness, never run. config-avx512.toml gains -Dwarnings to match config-v4.toml. Debug info is 0 for every artifact in the job. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh
|
Warning Review limit reachedYour organization has reached its usage spending cap. Adjust your spending cap in the billing tab. Next included review available in 43 minutes. View limit details
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Comment |
linux-build-v4 becomes a matrix over x86-64-v4 and sapphirerapids, each compiled and linked with --target and run nowhere. Companion: AdaWorldAPI/ndarray#361. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
…-spr-check # Conflicts: # .claude/blackboard.md
Why
Production runs on x86-64-v4 or better, and Railway hosts are Sapphire Rapids, Emerald Rapids or newer. lance-graph's canonical deploy file (
Dockerfile.avx512, AdaWorldAPI/lance-graph#1529) now buildssapphirerapids. Until now ndarray's CI compiled only the v4 arm, so the code thatsapphirerapidsturns on (VNNI, BF16, FP16) was never compiled in CI.Change
tier4-avx512-checkinci.yamlbecomes a two-entry matrix:x86-64-v4(.cargo/config-v4.toml) andsapphirerapids(.cargo/config-avx512.toml). Each entry runs bothcargo checkfeature sets and the asm-only codegen witness. Nothing is executed; GitHub's runners are mostly v3..cargo/config-avx512.tomlgains-Dwarnings, matchingconfig-v4.toml. A second quoted--configwould not work instead:codegen-witness.shword-splitsCARGO_ARGS, so the quotes would reach cargo literally.CARGO_PROFILE_DEV_DEBUG=0,CARGO_PROFILE_TEST_DEBUG=0andCARGO_INCREMENTAL=0. With--target, build scripts no longer get RUSTFLAGS-style flags and take the profile's debug level instead.Measured (local, Cascade Lake host, so nothing was run)
cargo check --target x86_64-unknown-linux-gnuatsapphirerapidswith-Dwarningspasses forapprox,serde,rayonandapprox,serde,rayon,hpc-extras.cargo check -vshows ndarray's rustc call receiving-Ctarget-cpu=native, then-Ctarget-cpu=sapphirerapids(the later flag wins), then-Dwarnings.WITNESS_NO_RUN=1 CARGO_ARGS="--config .cargo/config-avx512.toml" scripts/codegen-witness.sh avx512: PASS (1, 1 and 6vpternlog).Open
env -u RUSTFLAGSdrops the global crypto cfgs (dalek, poly1305), as it did before; unchanged here.Blackboard updated in the same commit.
🤖 Generated with Claude Code
https://claude.ai/code/session_011BMJnDBAfzcuQh5HeT39Rh
Generated by Claude Code