fix: skip yuv2rgb.cu compilation in CPU-only builds - #15811
Open
lilejin322 wants to merge 1 commit into
Open
Conversation
modules/drivers/camera/format:convert is a cuda_library, but its generated `:install` target is unconditionally pulled in by //modules/drivers/camera's own `:install` aggregation (apollo_package() adds a hard dependency on every subpackage's `:install`, regardless of platform). This forces yuv2rgb.cu to be compiled even for `bash apollo.sh build_cpu`, where it fails because gcc doesn't recognize .cu files without the CUDA toolchain. Gate the .cu source with if_cuda() so the library degrades to an empty target when CUDA isn't configured, instead of failing to compile. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
modules/drivers/camera/format:convert is a cuda_library, but its generated
:installtarget is unconditionally pulled in by //modules/drivers/camera's own:installaggregation (apollo_package() adds a hard dependency on every subpackage's:install, regardless of platform). This forces yuv2rgb.cu to be compiled even forbash apollo.sh build_cpu, where it fails because gcc doesn't recognize .cu files without the CUDA toolchain.Gate the .cu source with if_cuda() so the library degrades to an empty target when CUDA isn't configured, instead of failing to compile.