Repository navigation
Fix potential field planning without obstacles - #1479
Draft
huxiaoyi-ovo wants to merge 2 commits into
Draft
huxiaoyi-ovo wants to merge 2 commits into
huxiaoyi-ovo wants to merge 2 commits into
Conversation
Co-Authored-By: ChatGPT (OpenAI GPT-6) <noreply@openai.com>
Co-Authored-By: ChatGPT (OpenAI GPT-6) <noreply@openai.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Potential-field planning crashes on an obstacle-free map because the field bounds call
min(ox)/max(ox)on empty lists and the repulsive potential tries to index the nearest obstacle even when none exists.This change:
The behavior for maps with obstacles is unchanged.
Regression tests
(0, 0)toward(5, 5)and reaches within one grid resolution of the goal.Scope: 2 files (the planner and its tests), no API changes or new dependencies.
CI validation: fork PR #3 (Linux/macOS/Windows jobs launched).
AI assistance: ChatGPT (OpenAI GPT-6) helped inspect the edge case, implement the fix, and prepare regression tests.