fix(sol): use pinned compiler for bb sol build#24620
Merged
Merged
Conversation
fcarreiro
approved these changes
Jul 9, 2026
This was referenced Jul 9, 2026
fcarreiro
pushed a commit
that referenced
this pull request
Jul 9, 2026
## Summary - Backport the Foundry config fix from [#24620](#24620) to `merge-train/spartan`. - Move the `barretenberg/sol` `solc` setting into `[profile.default]` so Foundry actually uses `../../l1-contracts/solc-0.8.30`. ## Why [#24620](#24620) fixed the v5 train after `bb-sol` ignored the intended pinned compiler and fell back to Foundry's SVM download path. `merge-train/spartan` had the same TOML scoping issue. ## Verification - `forge config --json` in `barretenberg/sol` reports `"solc": "../../l1-contracts/solc-0.8.30"`. - `make bb-sol` passed. --- *Created by [claudebox](https://claudebox.work/v2/sessions/2b8c305bd7244e7e) · group: `slackbot`*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
barretenberg/solFoundrysolcsetting into[profile.default].bb-soluse the compiler already downloaded byl1-contracts-solcinstead of invoking Foundry's SVM network installer duringforge build.Investigation
PR #24606 entered the merge queue at 2026-07-08 22:51:37 UTC and was removed at 23:03:01 UTC. The failing merge-group run was CI3 run 28981250165 on queue SHA
fddbdbb79591f5cda6fa6450157e180cbfddb89f.The failed status was
ci/a1-fast; the underlyingbb-sollog showsforge buildinbarretenberg/soltried to installsolc 0.8.30fromraw.githubusercontent.com/nikitastupin/solc/.../linux/aarch64/solc-v0.8.30and got HTTP 429.l1-contracts-solchad already succeeded from cache, so the problem was that Foundry ignored the pinned compiler setting because it was scoped under[fuzz].Verification
forge config --jsoninbarretenberg/solnow reports"solc": "../../l1-contracts/solc-0.8.30"../bootstrap.sh download_solcinl1-contractspassed.make bb-solpassed../bootstrap.sh ciwas attempted but this branch's root bootstrap does not defineci(Unknown command: ci; available modes areci-fast,ci-full,ci-full-no-test-cache)../bootstrap.sh ci-fastwas attempted; the local workspace stopped beforebb-solbecause.claude/tests/agents_symlink_testfails against the harness-providedAGENTS.md/agents symlink layout. The affectedbb-soltarget was verified directly above.Created by claudebox · group:
slackbot