Skip to content

fix(sol): use pinned compiler for bb sol build#24620

Merged
fcarreiro merged 1 commit into
merge-train/spartan-v5from
cb/fix-spartan-v5-solc-download
Jul 9, 2026
Merged

fix(sol): use pinned compiler for bb sol build#24620
fcarreiro merged 1 commit into
merge-train/spartan-v5from
cb/fix-spartan-v5-solc-download

Conversation

@AztecBot

@AztecBot AztecBot commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Move the barretenberg/sol Foundry solc setting into [profile.default].
  • This makes bb-sol use the compiler already downloaded by l1-contracts-solc instead of invoking Foundry's SVM network installer during forge build.

Investigation

PR #24606 entered the merge queue at 2026-07-08 22:51:37 UTC and was removed at 23:03:01 UTC. The failing merge-group run was CI3 run 28981250165 on queue SHA fddbdbb79591f5cda6fa6450157e180cbfddb89f.

The failed status was ci/a1-fast; the underlying bb-sol log shows forge build in barretenberg/sol tried to install solc 0.8.30 from raw.githubusercontent.com/nikitastupin/solc/.../linux/aarch64/solc-v0.8.30 and got HTTP 429. l1-contracts-solc had already succeeded from cache, so the problem was that Foundry ignored the pinned compiler setting because it was scoped under [fuzz].

Verification

  • forge config --json in barretenberg/sol now reports "solc": "../../l1-contracts/solc-0.8.30".
  • ./bootstrap.sh download_solc in l1-contracts passed.
  • make bb-sol passed.
  • ./bootstrap.sh ci was attempted but this branch's root bootstrap does not define ci (Unknown command: ci; available modes are ci-fast, ci-full, ci-full-no-test-cache).
  • ./bootstrap.sh ci-fast was attempted; the local workspace stopped before bb-sol because .claude/tests/agents_symlink_test fails against the harness-provided AGENTS.md/agents symlink layout. The affected bb-sol target was verified directly above.

Created by claudebox · group: slackbot

@AztecBot AztecBot added ci-draft Run CI on draft PRs. ci-no-fail-fast Sets NO_FAIL_FAST in the CI so the run is not aborted on the first failure claudebox Owned by claudebox. it can push to this PR. labels Jul 8, 2026
@fcarreiro fcarreiro marked this pull request as ready for review July 9, 2026 08:24
@fcarreiro fcarreiro enabled auto-merge (squash) July 9, 2026 08:24
@fcarreiro fcarreiro merged commit 3adb172 into merge-train/spartan-v5 Jul 9, 2026
43 of 47 checks passed
@fcarreiro fcarreiro deleted the cb/fix-spartan-v5-solc-download branch July 9, 2026 08:25
fcarreiro pushed a commit that referenced this pull request Jul 9, 2026
## Summary
- Backport the Foundry config fix from
[#24620](#24620) to
`merge-train/spartan`.
- Move the `barretenberg/sol` `solc` setting into `[profile.default]` so
Foundry actually uses `../../l1-contracts/solc-0.8.30`.

## Why
[#24620](#24620)
fixed the v5 train after `bb-sol` ignored the intended pinned compiler
and fell back to Foundry's SVM download path. `merge-train/spartan` had
the same TOML scoping issue.

## Verification
- `forge config --json` in `barretenberg/sol` reports `"solc":
"../../l1-contracts/solc-0.8.30"`.
- `make bb-sol` passed.

---
*Created by
[claudebox](https://claudebox.work/v2/sessions/2b8c305bd7244e7e) ·
group: `slackbot`*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-draft Run CI on draft PRs. ci-no-fail-fast Sets NO_FAIL_FAST in the CI so the run is not aborted on the first failure claudebox Owned by claudebox. it can push to this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants