Skip to content

Mobile: fix Settings sheet header overlap, Done and light-mode cards - #1885

Merged
DoodleBears merged 2 commits into
mainfrom
claude/project-thread-6l6d2n
Oct 15, 2026
Merged

DoodleBears merged 2 commits into
mainfrom
claude/project-thread-6l6d2n

Conversation

@DoodleBears

Copy link
Copy Markdown
Contributor

Requested by Vain · project thread

Why the change

Follow-up to #1857 (#1850). The simulator batch found three bugs in the new Settings sheet:

  • The title and Done overlapped the Connections group.
  • Done did nothing; only swipe-down closed the sheet.
  • In light mode the groups had no card background.

Special things to note

  • The cause of the overlap is the native formSheet: it stretched the ScrollView over the sibling title row, which also swallowed Done taps. The title row now sits inside the ScrollView content, so nothing can cover it.
  • The groups now use SHEET_GROUP (the raised layer), as the model sheet and message actions do. In light mode that is a grey card on the white sheet; in dark mode it is lighter than the sheet base.
  • The host-look editor uses the same title-row pattern but is outside this fix.
  • Light and dark simulator screenshots will be posted as PR comments by the simulator queue.

Change outline

  • apps/mobile/src/ui/settings-view.tsx: the ScrollView is the root, the title row is its first child, and sections and rows pass on={SHEET_GROUP}.
  • apps/mobile/test/settings-sheet.test.tsx: mocks safe-area context for the new import.
  • changes/1850-mobile-settings-sheet-fixes.md: Fixed fragment.

Refs #1850

🤖 Generated with Claude Code

https://claude.ai/code/session_01P4McGrxLaXPVxUuUd2e7xZ


Generated by Claude Code

The title row now scrolls with the groups instead of sitting beside the
ScrollView, which the formSheet stretched over it, so Done is tappable
again. Groups use the raised sheet layer so they read as cards on the
white light-mode sheet.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01P4McGrxLaXPVxUuUd2e7xZ
@coderabbitai

coderabbitai Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 58 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 2fbf1f2b-fd93-4d4a-9e17-c76e28006604
📥 Commits

Reviewing files that changed from the base of the PR and between 0bfbc6a and cb0443a.

📒 Files selected for processing: 3
  • apps/mobile/src/ui/settings-view.tsx
  • apps/mobile/test/settings-sheet.test.tsx
  • changes/1850-mobile-settings-sheet-fixes.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

…-6l6d2n

# Conflicts:
#	apps/mobile/src/ui/settings-view.tsx
@DoodleBears

Copy link
Copy Markdown
Contributor Author

Batch QA — iOS Simulator (PR1800 glass, iOS 26), head cb0443a

Base: qa/batch-2 (main 0bfbc6a + batch). Screenshots redacted (host name / tailnet URL hidden).

Step Result
Title and Done no longer overlap the Connections section (light + dark) ✅ pass
Done closes the sheet ✅ pass
Light-mode rows have card backgrounds ✅ pass
No dim overlay left after closing ✅ pass
App icon row present ✅ pass
Android untested

Before (#1857 on main, the bugs this fixes): Before light Before dark

After: After light After dark

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants