Repository navigation
Mobile: fix Settings sheet header overlap, Done and light-mode cards - #1885
Merged
Merged
Conversation
The title row now scrolls with the groups instead of sitting beside the ScrollView, which the formSheet stretched over it, so Done is tappable again. Groups use the raised sheet layer so they read as cards on the white light-mode sheet. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01P4McGrxLaXPVxUuUd2e7xZ
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 58 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…-6l6d2n # Conflicts: # apps/mobile/src/ui/settings-view.tsx
Contributor
Author
Batch QA — iOS Simulator (PR1800 glass, iOS 26), head cb0443aBase:
Before (#1857 on main, the bugs this fixes): |
7 tasks
This was referenced Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Requested by Vain · project thread
Why the change
Follow-up to #1857 (#1850). The simulator batch found three bugs in the new Settings sheet:
Special things to note
SHEET_GROUP(the raised layer), as the model sheet and message actions do. In light mode that is a grey card on the white sheet; in dark mode it is lighter than the sheet base.Change outline
apps/mobile/src/ui/settings-view.tsx: the ScrollView is the root, the title row is its first child, and sections and rows passon={SHEET_GROUP}.apps/mobile/test/settings-sheet.test.tsx: mocks safe-area context for the new import.changes/1850-mobile-settings-sheet-fixes.md: Fixed fragment.Refs #1850
🤖 Generated with Claude Code
https://claude.ai/code/session_01P4McGrxLaXPVxUuUd2e7xZ
Generated by Claude Code