refactor(views): replace obsolete Watermark with PlaceholderText - #140
Merged
Conversation
Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
DeepDiver1975
force-pushed
the
fix/autocompletebox-placeholder
branch
from
August 27, 2026 09:12
264e60c to
3dae01c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replaces the obsolete Avalonia
Watermarkproperty withPlaceholderTexton 37 control attributes across 8 views, eliminating all 72AVLN5001"obsolete: Use PlaceholderText instead" warnings from the build.AutoCompleteBoxattributes: EtbView, ForcesView, MasterDataEditorView, OperatorPromptView, RolesView, ScbaViewTextBoxattributes: EtbView, FilesView, ForcesView, IncidentWorkspaceView, MasterDataEditorView, OperatorPromptView, RolesViewTheme/Styles.axamltemplate-part selectors (PART_Watermark/PART_FloatingWatermark) are intentionally untouched — those are internal template part names, not the obsolete property.Why
Watermarkis a pure alias forPlaceholderTextin Avalonia 12 (get => PlaceholderText; set => PlaceholderText = value;), so this is a behavior-identical rename that clears 72 obsolete-API build warnings.Verification
LageBuch.App.SharedandLageBuch.App: clean build, 0 warnings / 0 errorsScreenshots
PENDING — the headless render harness cannot run in the build sandbox (xunit.v3 test-process launch fails; pre-existing and reproduced on pristine
main). This is a visual no-op alias rename (placeholder text, color, and behavior are identical), so visual impact is nil. Screenshots will be supplied from a local render before merge.