London | 26-SDC-Mar | Craig D'Silva | Sprint 2 | Improve code with precomputing#200
Open
craig-dsilva wants to merge 2 commits into
Open
London | 26-SDC-Mar | Craig D'Silva | Sprint 2 | Improve code with precomputing#200craig-dsilva wants to merge 2 commits into
craig-dsilva wants to merge 2 commits into
Conversation
craig-dsilva
added
🏕 Priority Mandatory
cjyuan
reviewed
Jul 1, 2026
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Code looks good.
Could you also use complexity to show how much improvement your approaches have made?
| count_letters returns the number of letters which only occur in upper case in the passed string. | ||
| """ | ||
| only_upper = set() | ||
| lowercase_letters = {letter for letter in s if not is_upper_case(letter)} |
There was a problem hiding this comment.
The variable name is a bit misleading because it is a set of "all letters that's not uppercase letter", including digits, symbols, etc.
cjyuan
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Code now executes faster with precomputing.