London | 26-SDC-Mar | Craig D'Silva | Sprint 2 | Improve code with precomputing

Sprint-2/improve_with_precomputing/common_prefix/common_prefix.py

@@ -7,12 +7,17 @@ def find_longest_common_prefix(strings: List[str]):
 
     In the event that an empty list, a list containing one string, or a list of strings with no common prefixes is passed, the empty string will be returned.
     """
+    if len(strings) < 2:
+        return ""
+
+    sorted_strings = sorted(strings)
     longest = ""
-    for string_index, string in enumerate(strings):
-        for other_string in strings[string_index+1:]:
-            common = find_common_prefix(string, other_string)
-            if len(common) > len(longest):
-                longest = common
+
+    for i in range(len(sorted_strings) - 1):
+        common = find_common_prefix(sorted_strings[i], sorted_strings[i + 1])
+        if len(common) > len(longest):
+          longest = common
+
     return longest
 
 

Sprint-2/improve_with_precomputing/count_letters/count_letters.py

@@ -3,10 +3,10 @@ def count_letters(s: str) -> int:
     count_letters returns the number of letters which only occur in upper case in the passed string.
     """
     only_upper = set()
+    lowercase_letters = {letter for letter in s if not is_upper_case(letter)}
     for letter in s:
-        if is_upper_case(letter):
-            if letter.lower() not in s:
-                only_upper.add(letter)
+        if letter.lower() not in lowercase_letters:
+            only_upper.add(letter)
     return len(only_upper)