Repository navigation
Cape Town | 26-ITP-Sept | Vaidah Simenti | Sprint 1 | coursework/format-clock-edge-cases - #1644
Open
Vaidah-dev wants to merge 1 commit into
Open
Vaidah-dev wants to merge 1 commit into
Vaidah-dev wants to merge 1 commit into
Conversation
Vaidah-dev
added
the
Needs Review
cjyuan
reviewed
Oct 5, 2026
cjyuan
left a comment
cjyuan
left a comment
Contributor
There was a problem hiding this comment.
Implementation and tests are good. Well done.
| function formatAs12HourClock(time) { | ||
|
|
||
| const hours = Number(time.slice(0, 2)); | ||
| const minutes = time.slice(3, 5); |
Contributor
There was a problem hiding this comment.
Note: The .slice() method supports negative indices, which count positions from the end of the string.
For example, str.slice(-3) returns the substring containing last three characters from str.
cjyuan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Task code
CYF-1197
Changelist
Added tests for edge cases to timeConverter.test.js
Fixed formatAs12HourClock to handle: Midnight and Noon.
Fixed afternoon time padding and minute.
All tests pass.