Skip to content

Cape Town | 26-ITP-Sept | Vaidah Simenti | Sprint 1 | coursework/format-clock-edge-cases #1644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Vaidah-dev wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Cape Town | 26-ITP-Sept | Vaidah Simenti | Sprint 1 | coursework/format-clock-edge-cases #1644

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions format-clock-edge-cases/timeConverter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,19 @@
function formatAs12HourClock(time) {

const hours = Number(time.slice(0, 2));
const minutes = time.slice(3, 5);

@cjyuan cjyuan Oct 5, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: The .slice() method supports negative indices, which count positions from the end of the string.
For example, str.slice(-3) returns the substring containing last three characters from str.


if (hours === 0) {
return `12:${minutes} am`;
}

if (hours === 12) {
return `12:${minutes} pm`;
}

if (hours > 12) {
return `${hours - 12}:00 pm`;
return `${String(hours - 12).padStart(2, "0")}:${minutes} pm`;
}
return `${time} am`;
}

export {formatAs12HourClock};
export { formatAs12HourClock };
38 changes: 33 additions & 5 deletions format-clock-edge-cases/timeConverter.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,39 @@
import {formatAs12HourClock} from "./timeConverter.js";
import { formatAs12HourClock } from "./timeConverter.js";
import assert from "node:assert";
import test from "node:test";

test("correctly convert time after 12:00", function(){
assert.equal(formatAs12HourClock("23:00"), "11:00 pm");
test("correctly convert time after 12:00", () => {
assert.equal(formatAs12HourClock("23:00"), "11:00 pm");
});

test("can correctly convert morning time", function() {
assert.equal(formatAs12HourClock("08:00"), "08:00 am");
test("can correctly convert morning time", () => {
assert.equal(formatAs12HourClock("08:00"), "08:00 am");
});

test("handles midnight correctly", () => {
assert.equal(formatAs12HourClock("00:00"), "12:00 am");
});

test("handles noon correctly", () => {
assert.equal(formatAs12HourClock("12:00"), "12:00 pm");
});

test("handles noon with minutes", () => {
assert.equal(formatAs12HourClock("12:30"), "12:30 pm");
});

test("handles afternoon time with leading zero", () => {
assert.equal(formatAs12HourClock("13:00"), "01:00 pm");
});

test("handles afternoon time with minutes", () => {
assert.equal(formatAs12HourClock("23:45"), "11:45 pm");
});

test("handles early morning with leading zero", () => {
assert.equal(formatAs12HourClock("01:00"), "01:00 am");
});

test("handles just before noon", () => {
assert.equal(formatAs12HourClock("11:59"), "11:59 am");
});
Loading