Repository navigation
Cape Town | sep-2026-ITP | Matthaus Bause | Sprint 1 | Time Clock - #1648
Open
chefmatthaus-hub wants to merge 3 commits into
Open
chefmatthaus-hub wants to merge 3 commits into
chefmatthaus-hub wants to merge 3 commits into
Conversation
cjyuan
reviewed
Oct 5, 2026
cjyuan
reviewed
Oct 8, 2026
cjyuan
left a comment
Contributor
There was a problem hiding this comment.
Could you include a Changelist section in your PR description?
Contributor
There was a problem hiding this comment.
Not all statements are terminated by a semicolon and spacing around { and '}` is not fully consistent.
Suggestion:
- Look up the benefits of using a code formatter.
- Install the Prettier extension for VS Code, then:
- Use VS Code's Format Document feature to format your code.
- Optionally, enable Format On Save and Format On Paste to keep your code consistently formatted.
Resource: Visual Studio Code - Formatting
Note: The formatter may not work correctly if your code contains syntax errors.
Contributor
There was a problem hiding this comment.
Could you check whether the expected return values specified in the tests use a consistent format?
When a function's return values are not consistently formatted, it can lead to unintended side effects. For examples:
- When the formatted strings are displayed, they may not align nicely:
01:00 am
1:00 pm
12:00 am
01:00 pm
02:00pm
- When the formatted strings are compared in a program, they may produce unexpected results:
"1:00 pm" < "11:00 pm"evaluates tofalse"01:00 am" < "11:00 am"evaluates totrue
For this reason, it would be better to ensure that the function always returns values in a consistent format.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Task code
CYF-1197