Skip to content

Cape Town | sep-2026-ITP | Matthaus Bause | Sprint 1 | Time Clock #1648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chefmatthaus-hub wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Cape Town | sep-2026-ITP | Matthaus Bause | Sprint 1 | Time Clock #1648

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2ec464d
Refactor time conversion logic and enhance test coverage for edge cases
chefmatthaus-hub Oct 5, 2026
0795731
Refactor time conversion logic and add tests for edge cases including…
chefmatthaus-hub Oct 7, 2026
7753fc4
Enhance test coverage for single-digit morning hours in time conversion
chefmatthaus-hub Oct 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions format-clock-edge-cases/timeConverter.js
View file
Open in desktop

@cjyuan cjyuan Oct 8, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not all statements are terminated by a semicolon and spacing around { and '}` is not fully consistent.

Suggestion:

  • Look up the benefits of using a code formatter.
  • Install the Prettier extension for VS Code, then:
    • Use VS Code's Format Document feature to format your code.
    • Optionally, enable Format On Save and Format On Paste to keep your code consistently formatted.

Resource: Visual Studio Code - Formatting

Note: The formatter may not work correctly if your code contains syntax errors.

Original file line number Diff line number Diff line change
@@ -1,11 +1,23 @@
function formatAs12HourClock(time) {

const [hoursStr, minutesStr] = time.split(':');
const hours = Number(hoursStr);
const minutes = minutesStr;

const hours = Number(time.slice(0, 2));
if (hours === 0 || hours === 24) {
return `12:${minutes} am`
}

if (hours === 12) {
return `12:${minutes} pm`
}

if (hours > 12) {
return `${hours - 12}:00 pm`;
return `${hours - 12}:${minutes} pm`;
}
return `${time} am`;

const formattedHours = String(hours).padStart(2, '0');
return `${formattedHours}:${minutes} am`;
}

export {formatAs12HourClock};
export {formatAs12HourClock};
88 changes: 86 additions & 2 deletions format-clock-edge-cases/timeConverter.test.js
View file
Open in desktop
Comment thread
cjyuan marked this conversation as resolved.

@cjyuan cjyuan Oct 8, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you check whether the expected return values specified in the tests use a consistent format?

When a function's return values are not consistently formatted, it can lead to unintended side effects. For examples:

  1. When the formatted strings are displayed, they may not align nicely:
01:00 am
1:00 pm
12:00 am
01:00 pm
02:00pm
  1. When the formatted strings are compared in a program, they may produce unexpected results:
  • "1:00 pm" < "11:00 pm" evaluates to false
  • "01:00 am" < "11:00 am" evaluates to true

For this reason, it would be better to ensure that the function always returns values in a consistent format.

Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,94 @@ import {formatAs12HourClock} from "./timeConverter.js";
import assert from "node:assert";
import test from "node:test";

test("correctly convert time after 12:00", function(){
test("correctly convert hours after 12:00", () => {
assert.equal(formatAs12HourClock("23:00"), "11:00 pm");
});

test("can correctly convert morning time", function() {
test("correctly convert minutes after 12:00", () => {
assert.equal(formatAs12HourClock("23:53"), "11:53 pm");
});

test("can correctly convert morning time", () => {
assert.equal(formatAs12HourClock("08:00"), "08:00 am");
});

test("can correctly convert morning time minutes", () => {
assert.equal(formatAs12HourClock("08:30"), "08:30 am");
});

test("can correctly convert morning time minutes", () => {
assert.equal(formatAs12HourClock("08:34"), "08:34 am");
});

test("can successfully convert midnight time", () =>
assert.equal(formatAs12HourClock("24:00"), "12:00 am"));
Comment thread
cjyuan marked this conversation as resolved.

test("correctly convert midnight 00:00", () => {
assert.equal(formatAs12HourClock("00:00"), "12:00 am");
});

test("correctly convert noon 12:00", () => {
assert.equal(formatAs12HourClock("12:00"), "12:00 pm");
});

test("correctly convert boundary time around noon", () => {
assert.equal(formatAs12HourClock("11:59"), "11:59 am");
assert.equal(formatAs12HourClock("12:01"), "12:01 pm");
});

test("correctly convert early afternoon hours", () => {
assert.equal(formatAs12HourClock("13:00"), "1:00 pm");
});

test("correctly convert single-digit morning hours if supported", () => {
assert(formatAs12HourClock("08:30"), "8:30am");
});

/*
Edge cases:
Correctly convert hours after 12:00
Input | Expected
23:00 11:00 pm

Correctly convert afternoon hours and minutes
Input | Expected
23:00 11:53 pm

Correctly convert morning time and minutes
Input | Expected
08:00 08:00 am

Correctly convert morning time and minutes
Input | Expected
08:30 08:30 am

Correctly convert morning time and minutes
Input | Expected
08:34 08:34 am

Correctly convert midnight time
Input | Expected
24:00 12:00 am

Correctly convert midnight
Input | Expected
00:00 12:00 am

Correctly convert noon
Input | Expected
12:00 12:00 pm

Correctly convert boundary time around noon
Input | Expected
11:59 11:59 am
12:01 12:01 pm

Correctly convert early afternoon hours
Input | Expected
13:00 1:00 pm

Correctly convert single-digit morning hours if supported
Input | Expected
08:30 8:30 am
*/
Loading