Repository navigation
Conversation
ausiejute
added
📅 Sprint 1
Luro91
added
the
Review in progress
Luro91
reviewed
Oct 6, 2026
Luro91
left a comment
Luro91
left a comment
There was a problem hiding this comment.
Well done. The code covers the edge cases now and also includes tests for them.
Luro91
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Task Code
CYF-1197
Changelist
Identified and wrote tests for important edge cases that use the formatAs12HourClock function and fixed the code so that it works correctly for all valid inputs.